Setpoint Academy — feature audit

Repo: /Users/Alvaro/cowork/setpoint (read-only audit, 2026-09-16). All paths relative to that root.

Totals: HAVE 12 · PARTIAL 12 · MISSING 6 (30 rows).

Feature matrix

(a) Academy directories

Admin pages under apps/admin/src/app/[facility]/academy: classes, coaches, coaches/[id], lessons, packages, payments, planning, reports, setup, students, students/[userId], students/groups, students/groups/[id], plus the module landing page.tsx. Thirteen page files in total.

Academy-related routes under apps/admin/src/app/api/admin:

• academies, academies/[id]/facilities, academies/[id]/focus-areas, academies/[id]/focus-areas/[faId]
• academy-groups, academy-groups/[id], academy-groups/[id]/members, academy-groups/[id]/members/[userId]
• academy-payments, academy-payments/_lib, academy-payments/reminders, academy-payments/revert, academy-payments/settings, academy-payments/summary
• academy-reports
• classes, classes/[id]
• coaches, coaches/[id], coaches/[id]/schedule
• lessons, lessons/[id], lessons/[id]/ai-feedback, lessons/[id]/analyze-video, lessons/[id]/assign-coach, lessons/[id]/payment-link, lessons/[id]/payment-link/email, lessons/[id]/players, lessons/[id]/roster, lessons/[id]/students, lessons/_lib, lessons/recurring
• lesson-packages, lesson-packages/[id], player-packages, packages, students
• Adjacent and shared: programs, message-templates, payment-requests, group-report-subscriptions, report-access, report-subscriptions, crm/*

(b) Acceptance-criteria and decisions files

Under apps/docs/src/data:

Eight files, 215 acceptance criteria. decisions.ts holds 352 DEC- entries (DEC-320/321/322/323/327 are the load-bearing ones for academy payments). Supporting plans and guides: plan-coach-availability-overhaul.ts, plan-coach-booking-openrally.ts, plan-lesson-per-student-checkin.md, plan-booking-status-payment-checkin.md, plan-checkin-consolidation.md, coach-availability-guide.{md,ts}, ac-coach-availability-blocks-courts-toggle.ts, handoff-future-coach-mapping-automation.md, plus GROUP-COACHING-PLAN.md at the repo root.

(c) Test conventions

Database tests. There is no supabase/tests directory and no pgTAP files — no .test.sql or _test.sql anywhere. Database-level assertions live as eval scripts in supabase/snippets/ (8 files: academy_pos_bridge_evals.sql, coach_availability_booking_conflict_evals.sql, cross_window_pricing_evals.sql, discount_composition_evals.sql, discount_engine_evals.sql, events_payment_reconciliation_evals.sql, program_session_openrally_evals.sql, wallet_evals.sql) and are executed from Playwright by apps/admin/e2e/tc-000-sql-evals.e2e.ts.

Playwright. All specs are apps/admin/e2e/tc-*.e2e.ts under one config, run with cd apps/admin && npx playwright test in the foreground with a timeout at or under 600s; videos land in apps/admin/test-results/ as proof. Test cases are defined by the product owner at https://product-setpoint.vercel.app/test-cases. Shared helpers in apps/admin/e2e/test-helpers.ts export ADMIN_URL, WEB_URL, SUPABASE_URL and getOtpFromMailpit(); setup lives in auth.setup.ts, global-setup.ts, global-teardown.ts, setup-booking-data.ts, seed-crm-data.ts, with flows/ and demos/ subdirectories. Roughly 80 of the specs touch academy, coaching, packages or payments.

.claude/rules/e2e-testing.md requires, for any PR touching apps/admin/e2e/**:

• Each TC exercises a complete business flow end to end with assertions at every verification point.
• Self-contained data created in beforeAll via getSupabaseAdmin() and cleaned in afterAll; no shared seed, no demo-populate, no ordering between tests, never read seed.sql.
• UI-first setup: if a feature adds or changes a form, the test must drive that form in the browser rather than bypassing it with inserts. Database setup only for things the test does not own.
• data-testid selectors only, never Tailwind classes.
• Assert rendered values, not just the database.
• Never skip: no test.skip(), no if (visible) {…} else {…}, no .catch(() => {}) around assertions, no conditional assertion blocks. A missing element is a bug; fix the selector.
• Cross-page verification: assert the change on every page that shows it, including the public web app and academy reports.
• Native-equivalence for Setpoint↔︎TPS: verify all three legs (TPS booking_third_party_references, OpenRally GET /bookings/{uuid}, Setpoint bookings).
• Stepper coverage: back at every step, chained backs, forward-after-back, back mid-async, back while a hold or timer is live.
• Slot and resource blocking, currency formatting (e.g. THB 1,400.00, no raw minor units leaking), idempotent timestamp-based data, parallel safety.
• OTP via Mailpit locally (port = Supabase port + 3); no Mailosaur locally. Never networkidle with Supabase Realtime — use domcontentloaded.
• Against a production database: no automated cleanup, and never write DELETE or UPDATE … WHERE from test code.

.claude/rules/docs-sync.md requires, for any PR touching apps/docs/src/data/**, apps/apidocs/src/data/**, apps/admin/src/app/api/**, supabase/migrations/** or packages/database/src/**: update versions.ts (including the e2eTests count and feature list), feature-matrix.ts (endpoint counts, new rows), deployment.ts, monthly-planning.ts (goal status), and any prd-*.ts; also CLAUDE.md, apps/apidocs/src/data/api-reference.ts and a regenerated packages/database/src/database.types.ts when affected. Then build both docs apps (cd apps/docs && npm run build, cd apps/apidocs && npm run build) to catch errors. A pre-commit hook warns when docs files are missing.

Other rule files: .claude/rules/migrations.md (one-shot migration rules), coach-availability.md, openrally-integration.md.

(d) PR and post-merge deployment checklist in CLAUDE.md

Feature workflow (line 102), 13 steps: select and sequence → clarify, blocking until zero ambiguity, logging answers as decisions → write ACs → plan → persist AC and plan as ac-<feature>.ts in a chore PR → build in atomic commits → E2E per .claude/rules/e2e-testing.md → self-review the full diff line by line → verify tests pass → sync docs per .claude/rules/docs-sync.md → merge prep → deploy → delete the ac- file in a chore PR.

Line 104 marks step 8 mandatory before merging: run git diff origin/main...HEAD, read every changed line, verify correctness before gh pr merge. Skipping it once shipped a critical bug where an is_active filter hid 129 live items from staff terminals.

Git and PR rules (lines 96-98): branches feature/ fix/ hotfix/ chore/; one feature = one branch = one PR; the pre-commit hook rejects direct-to-main; git fetch origin main && git merge origin/main before PR or merge, watching supabase/migrations/ ordering; merge with gh pr merge --squash --delete-branch, then git checkout main && git pull. The PR description must contain TLDR, root cause, file-by-file changes, reasoning and trade-offs, and agent-context written for a zero-context reader. New columns must be justified with what was checked and ruled out (line 37). A patch that ships ahead of the architectural fix must be labelled a patch in the PR with the follow-up filed (line 33).

Code review (line 117) is mandatory before deploy. Demo before PR (lines 121-123) is mandatory when the PR needs sign-off: a narrated screen recording, or a clear GIF/screenshot walkthrough, attached to the PR or sent with the link. A written summary is explicitly not a substitute.

Post-merge deployment (line 152): Vercel auto-deploys each app independently on merge. Manual steps after merge are: run any new DB migration with supabase db query --linked --file supabase/migrations/<file>.sql (NEW files only — supabase db push and supabase db reset --linked are permanently banned per line 20), deploy edge functions with supabase functions deploy <name> --project-ref utommwznukufegwhltqw, and for OpenRally cd protocol/server && flyctl deploy --remote-only. Then verify admin-setpoint, front-setpoint, product-setpoint and apidocs-setpoint. Never create a new Vercel project to make a deploy work (line 129 — the CLI paginates and hides projects past the first ~20), and always cd into the app's own directory before a manual deploy, or a root-level vercel --prod will deploy whatever the root is linked to.